feat: adds zksync to network configuration #5066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackHamer09
suggested changes
Sep 20, 2023
|
@benisgold hey there 👋 I am hoping to finish up this PR, do you mind giving me some clarity on this variable "balanceCheckerAddress"? |
dutterbutter
requested review from
benisgold,
skylarbarrera and
jinchung
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am making this a DRAFT PR as there is an item I require assistance / context from Rainbow team for the following:
balanceCheckerAddress? I see its a contract, and the comment suggests "Check all the ETH balances at once". I have left this field blank until further direction is provided.What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test