gas: l1 optimism fee estimation #5077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APP-799 op chain gas estimation is offf
we are showing gas estimations that are cheaper than the actual txs are are submitting |
benisgold
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-799
What changed (plus any additional context for devs)
we were not adding the l1 fee to 1559 gas estimations since this code was initially only for mainnet
now we add it
Screen recordings / screenshots
https://cloud.skylarbarrera.com/Screen-Shot-2023-09-26-14-47-56.04.png
What to test
gas should match p close with the bx for op chain gas estimations