Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix swap percents formatting #5078

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

skylarbarrera
Copy link
Contributor

What changed (plus any additional context for devs)

small regression been around for a bit
before: https://cloud.skylarbarrera.com/Screenshot-2023-09-26-at-5.32.05-PM.png
after: https://cloud.skylarbarrera.com/Screenshot-2023-09-26-at-5.31.59-PM.png

Screen recordings / screenshots

What to test

Copy link
Contributor

@benisgold benisgold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also vertically center the pill with the rest of the line while youre at it 🙏 🥺

@skylarbarrera
Copy link
Contributor Author

could you also vertically center the pill with the rest of the line while youre at it 🙏 🥺

ty fixed https://cloud.skylarbarrera.com/Screenshot-2023-09-26-at-5.48.16-PM.png

@skylarbarrera skylarbarrera merged commit 739c82b into develop Sep 28, 2023
@skylarbarrera skylarbarrera deleted the @skylar/fix-swaping-via-percent branch September 28, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants