Fix android loading state on new wallets #5082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APP-762 newWalletFlow: empty wallet state can get stuck on loading
this loading state could have been affected but the REST endpoint changes |
jinchung
changed the title
jinchung
force-pushed
the
@jin/empty-wallets-loading
branch
from
f672247 to
cdbb53a
Compare
dereknelson
approved these changes
Sep 28, 2023
skylarbarrera
approved these changes
Sep 28, 2023
| @@ -144,6 +147,9 @@ async function userAssetsQueryFunction({ | |||
|
|
|||
| return parsedSuccessResults; | |||
| } catch (e) { | |||
| dispatch({ | |||
There was a problem hiding this comment.
so this is happening because we are trying to load data that does not exist?
jinchung
force-pushed
the
@jin/empty-wallets-loading
branch
from
cdbb53a to
e9451e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-762
Testing instructions in Linear