Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

links: fix profiles #5088

Merged
merged 2 commits into from
Oct 4, 2023
Merged

links: fix profiles #5088

merged 2 commits into from
Oct 4, 2023

Conversation

skylarbarrera
Copy link
Contributor

Fixes APP-833

What changed (plus any additional context for devs)

context is in the ticket

Screen recordings / screenshots

https://cloud.skylarbarrera.com/Screen-Recording-2023-10-02-20-54-27.mp4

What to test

web profiles should open in the app as expected

@linear
Copy link

linear bot commented Oct 3, 2023

APP-833 Profiles Deeplinks are broken

new website uses /profile which means we need to change our handling on the client

@skylarbarrera skylarbarrera requested review from walmat, dereknelson and benisgold and removed request for brunobar79 October 3, 2023 04:00
Copy link
Contributor

@dereknelson dereknelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jinchung jinchung merged commit a0bf003 into develop Oct 4, 2023
4 of 5 checks passed
@jinchung jinchung deleted the @skylar/fix-profile-deeplinks branch October 4, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants