Fix crashes resulting from react-native-screens Activity restart on Android #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android As per the react-native-screens documentation on Android setup: Discards any Activity state persisted during the Activity restart process, to avoid inconsistencies that lead to crashes.
APP-850 Crashlytics crash: react-native-screens misconfiguration on Android causes inconsistent crashes
Specific discussion thread on this issue: software-mansion/react-native-screens#17 (comment) recommended setup on Android on react-native-screens docs: https://console.firebase.google.com/u/0/project/rainbow-me/crashlytics/app/android:me.rainbow/issues/d6dbad6df4b2adaa929f915c12c31d80?time=last-thirty-days&types=crash&sessionEventKey=65215BDF032B000127A59267DE57F6D1_1865652296299398788 |
jinchung
commented
Oct 7, 2023
| @@ -10,7 +10,6 @@ | |||
| import me.rainbow.NativeModules.RNBackHandler.RNBackHandlerPackage; | |||
| import me.rainbow.NativeModules.Internals.*; | |||
| import android.webkit.WebView; | |||
| import com.facebook.react.ReactActivityDelegate; | |||
There was a problem hiding this comment.
removing as there is a duplicate on line 6
skylarbarrera
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the react-native-screens documentation on Android setup: Discards any Activity state persisted during the Activity restart process, to avoid inconsistencies that lead to crashes.
Linear ticket has broader context
Fixes APP-850
Requires this update to android preinstall hook: https://github.com/rainbow-me/rainbow-scripts/pull/133