Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx sim: warnings #5224

Merged
merged 2 commits into from
Dec 7, 2023
Merged

tx sim: warnings #5224

merged 2 commits into from
Dec 7, 2023

Conversation

skylarbarrera
Copy link
Contributor

Fixes APP-939

What changed (plus any additional context for devs)

added warnings to tx sim

Screen recordings / screenshots

https://cloud.skylarbarrera.com/Screen-Shot-2023-12-06-17-02-58.40.png

What to test

Copy link

linear bot commented Dec 6, 2023

@jinchung jinchung added the release for release blockers and release candidate branches label Dec 7, 2023
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@skylarbarrera skylarbarrera merged commit 36f922a into develop Dec 7, 2023
5 of 6 checks passed
@skylarbarrera skylarbarrera deleted the @skylar/maliciousness branch December 7, 2023 23:32
BrodyHughes added a commit that referenced this pull request Dec 11, 2023
…brody/QR-code-scanner-fixes

* 'develop' of https://github.com/rainbow-me/rainbow:
  fix special characters overflowing due to lineHeight (#5239)
  Optional chaining (#5232)
  tx sim: warnings (#5224)
  tx sim: enable zora (#5226)
  fix search not being able to scroll to bottom due to add bottom tab bar (#5227)
  Update Crowdin configuration file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release for release blockers and release candidate branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants