Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display implementation contract name for proxied contracts #5238

Closed
CodeSandwich opened this issue Dec 11, 2023 · 1 comment
Closed

Display implementation contract name for proxied contracts #5238

CodeSandwich opened this issue Dec 11, 2023 · 1 comment

Comments

@CodeSandwich
Copy link

Currently interacting with an upgradeable contract displays the name of the proxy contract and not the implementation contract. This is confusing, because the proxies usually have vague names that don't mean much to the users. It would be great if the underlying contract name was displayed instead.

An example of an interaction with the ManagedProxy contract that is an upgradeable proxy for the contract named Drips. It would be clearer if the notification said "sent 10 USDC to Drips", it's the name of the protocol that the user is familiar with. This is the contract: https://etherscan.io/address/0xd0Dd053392db676D57317CD4fe96Fc2cCf42D0b4.

image

I'm wildly speculating, but you probably are using Etherscan to get information about the contracts, and hey have very good proxy detection, do they expose information like the implementation contract in their API?

@welps
Copy link
Member

welps commented Dec 12, 2023

@CodeSandwich Hi, thanks for the report. We actually already do what you suggest and try to pick the better name.

HOWEVER, this can happen because sometiimes we pull this data before etherscan is aware of the implementation contract. We try to avoid hitting etherscan again due to its depressing rate limits (even on a paid plan) so this bad name sticks around.

We ticketed work internally to do some work to recrawl for names on proxy contracts. If you see any wonky names in the meantime, feel free to report to [email protected] as these names can be updated internally. I've updated the name for this particular contract and it should propagate in a few hours.

Thanks.

@welps welps closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants