Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APP-962]: Fix special characters overflowing due to lineHeight #5239

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Dec 11, 2023

Fixes APP-962

What changed (plus any additional context for devs)

tweaked some css to allow for special characters in featured mint titles

Screen recordings / screenshots

Screenshot 2023-12-11 at 9 35 41 AM Screenshot 2023-12-11 at 9 35 35 AM

What to test

@walmat walmat requested a review from skylarbarrera December 11, 2023 16:38
Copy link

linear bot commented Dec 11, 2023

Copy link
Contributor

@skylarbarrera skylarbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖖

@skylarbarrera skylarbarrera merged commit c4aca64 into develop Dec 11, 2023
5 of 6 checks passed
@skylarbarrera skylarbarrera deleted the @matthew/APP-962 branch December 11, 2023 17:43
BrodyHughes added a commit that referenced this pull request Dec 11, 2023
…brody/QR-code-scanner-fixes

* 'develop' of https://github.com/rainbow-me/rainbow:
  fix special characters overflowing due to lineHeight (#5239)
  Optional chaining (#5232)
  tx sim: warnings (#5224)
  tx sim: enable zora (#5226)
  fix search not being able to scroll to bottom due to add bottom tab bar (#5227)
  Update Crowdin configuration file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants