Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Points: Fix onboarding error #5257

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

benisgold
Copy link
Contributor

@benisgold benisgold commented Dec 13, 2023

Fixes APP-1001

What changed (plus any additional context for devs)

When the user signs in, signPersonalMessage is called. This function calls loadWallet which calls loadAddress. The error was occurring because loadAddress was loading the wrong address. I investigated this, but wasn't able to get to the bottom of it. To circumvent this issue, the user's accountAddress (which is correct) is now passed into a call to loadWallet which is passed into signPersonalMessage.

Ticket for overarching issue:
https://linear.app/rainbow/issue/APP-1010/loadaddress-may-return-wrong-address-after-wallet-creation

Screen recordings / screenshots

https://www.loom.com/share/02f23fa6cfcc4d7e82617ec903dd26cb

What to test

To repro on develop:

  1. switch to a watched wallet
  2. create a new wallet
  3. onboard to points
  4. error should occur when signing in

Copy link

linear bot commented Dec 13, 2023

Copy link
Contributor

@skylarbarrera skylarbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yessir

@skylarbarrera skylarbarrera merged commit 76f0057 into develop Dec 14, 2023
5 of 6 checks passed
@skylarbarrera skylarbarrera deleted the @benisgold/points-onboarding-fix branch December 14, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants