Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1001
What changed (plus any additional context for devs)
When the user signs in,
signPersonalMessage
is called. This function callsloadWallet
which callsloadAddress
. The error was occurring becauseloadAddress
was loading the wrong address. I investigated this, but wasn't able to get to the bottom of it. To circumvent this issue, the user'saccountAddress
(which is correct) is now passed into a call toloadWallet
which is passed intosignPersonalMessage
.Ticket for overarching issue:
https://linear.app/rainbow/issue/APP-1010/loadaddress-may-return-wrong-address-after-wallet-creation
Screen recordings / screenshots
https://www.loom.com/share/02f23fa6cfcc4d7e82617ec903dd26cb
What to test
To repro on
develop
: