Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Points: date formatting in next drop card #5263

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

benisgold
Copy link
Contributor

Fixes APP-1016

What changed (plus any additional context for devs)

  • display minutes in next drop time (mike wants it to say 4:20pm in EST)
  • say "Today" instead of day of week if drop is happening today

Screen recordings / screenshots

Simulator Screenshot - iPhone 14 Pro - 2023-12-13 at 22 35 50

What to test

Copy link

linear bot commented Dec 14, 2023

Copy link
Contributor

@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. nice touch 👍🏼

@jinchung jinchung merged commit 755bd2d into develop Dec 14, 2023
5 of 6 checks passed
@jinchung jinchung deleted the @benisgold/points-next-drop-time branch December 14, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants