[APP-1049]: (feat): Backups V2 #5310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* (feat): add backups global config * stash * add migration for setting initial backup method * add method to migrations array * revert pbx change * change backup status value
… and `backupStatus` (#5313) * [APP-1052]: (feat): adjust settings page row * fix migration and hook for useWallets * simplify an if statement
* wallets and backups screen progress * manual backups progress * progress * feat(backups): more work on wallets and backups * revert pbx * rev init wallet change * final touches on wallets and backup view
* save progress * cleanup and finish secret phrase / private key viewiing screens --------- Co-authored-by: Matthew Wall <[email protected]>
* progress on cloud backup flow * cloud backup flow progress
* progress on restore from cloud * progress on choose backup flow * f * test signed commit * backups v2 restore from icloud flow done * progress on restore step
walmat
requested review from
benisgold,
skylarbarrera and
jinchung
as code owners
benisgold
reviewed
Feb 6, 2024
…t prioritizing seed phrases
ibrahimtaveras00
approved these changes
Mar 25, 2024
brunobar79
approved these changes
Mar 27, 2024
| if (privateKeyAddress) { | ||
| const privateKeyData = await loadPrivateKey(privateKeyAddress, false); | ||
| if (privateKeyData === -1 || privateKeyData === -2 || !privateKeyData) { | ||
| setSectionState(SecretDisplayStates.noSeed); |
There was a problem hiding this comment.
I think this might be one of the places were we need to add the alert to contact support, just because this needs to be backwards compatible cc: @jin
| }, | ||
| async (buttonIndex: number) => { | ||
| if (buttonIndex === 0) { |
There was a problem hiding this comment.
are we removing the option to restore and older backup?
| const valueStr = backedUpData[key]; | ||
| const parsedValue = JSON.parse(valueStr); | ||
|
|
||
| let secretPhraseOrOldAndroidBackupPrivateKey: string | any; // TODO: Strengthen this type |
Co-authored-by: Bruno Barbieri <[email protected]>
Co-authored-by: Bruno Barbieri <[email protected]>
BrodyHughes
added a commit
that referenced
this pull request
Apr 2, 2024
* 'develop' of github.com:rainbow-me/rainbow: Only hold the active tab ref in BrowserContext (#5579) Dapp browser: disable tab closing for empty state (#5573) Browser: fix ref assignment, back/forward navigation (#5578) Browser: fully eliminate reloading issues (#5576) browser: static trending dapps (#5561) bump swaps sdk (#5574) fix gitignore (#5571) bump (#5570) Fix browser context menu not updating (#5569) ⚡️ Fast browser (#5566) [APP-1049]: (feat): Backups V2 (#5310) fix: search by contract address (#5563)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1049
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test