Dapp Browser + provider #5543
Dapp Browser + provider #5543
Conversation
brunobar79
requested review from
skylarbarrera,
benisgold and
jinchung
as code owners
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@rainbow-me/[email protected] |
| }; | ||
|
|
||
| const checkRateLimitFn = async (host: string) => { | ||
| // try { |
There was a problem hiding this comment.
I'll hook this up later
| const numericChainId = convertHexToString(chainId); | ||
| const supportedChainId = supportedChains.includes(numericChainId); | ||
| alert('Chain Id not supported'); | ||
| console.warn('PROVIDER TODO: TODO SEND NOTIFICATION'); |
There was a problem hiding this comment.
left this so we can add some toast later on
| appSessionsStore.getState().updateActiveSessionNetwork({ host: host, network: getNetworkFromChainId(Number(numericChainId)) }); | ||
| messenger.send(`chainChanged:${host}`, Number(numericChainId)); | ||
| } | ||
| console.warn('PROVIDER TODO: TODO SEND NOTIFICATION'); |
There was a problem hiding this comment.
left this so we can add some toast later on
| return response; | ||
| }; | ||
|
|
||
| const isSupportedChainId = (chainId: number) => RainbowNetworks.filter(network => Number(network.id) === chainId).length > 0; |
There was a problem hiding this comment.
i feel like this should be
const isSupportedChainId = (chainId: number) => !!RainbowNetworks.find(network => Number(network.id) === chainId);
There was a problem hiding this comment.
I feel like there shouldn't be networks at all but ok
There was a problem hiding this comment.
insert spiderman meme
| @@ -24,9 +24,9 @@ export type RequestType = 'walletconnect' | 'browser'; | |||
| // Dapp Browser | |||
|
|
|||
| export interface DappConnectionData { | |||
| dappName: string; | |||
| dappName?: string; | |||
There was a problem hiding this comment.
curious when this would be undefined
There was a problem hiding this comment.
a website without <title> tag
* 'develop' of github.com:rainbow-me/rainbow: Bump Rudderstack version to v1.12.1 (#5556) txs: detail sheet updates (#5535) browser: requests background color (#5562) fix: hide favs on non mainnet assets (#5565) balances: fetch twice tx confirm (#5551) [CHORE]: Remove Apollo client in favor of `@/graphql` (#5555) browser: favorites state + menu (#5553) init browser state (#5552) Dapp Browser: Search UI (#5542) Dapp Browser + provider (#5543) NFT offers/mints gas estimation improvements (#5448) State dump modifications (#5382) fix crash (#5544) [SWAPS V2]: Adjust asset types + utils to match BX (#5538)
Fixes APP-####
What changed (plus any additional context for devs)
Screen recordings / screenshots
https://recordit.co/TRKYEIOouD
What to test