Remove selectionColor prop
#5790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benisgold
reviewed
May 31, 2024
It's not really working on iOS currently either so let's remove and we can possibly re-add later |
christianbaroni
approved these changes
Jun 2, 2024
walmat
commented
Jun 3, 2024
| @@ -98,7 +98,7 @@ export const SearchInput = ({ | |||
|
|
|||
| return { | |||
| text: query, | |||
| selectionColor: getColorValueForThemeWorklet(asset.value?.highContrastColor, isDarkMode, true), | |||
| defaultValue: '', | |||
There was a problem hiding this comment.
i had to add this to get lint to pass, any idea @christianbaroni
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1539
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test