Fix BSC bridges #5855
Merged
Fix BSC bridges #5855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobar79
reviewed
Jun 17, 2024
Comment on lines
+339
to
+340
| buyAmountDisplay: isNativeWrapOrUnwrap ? quoteData.buyAmount : quoteData.buyAmountDisplay, | ||
| sellAmountDisplay: isNativeWrapOrUnwrap ? quoteData.sellAmount : quoteData.sellAmountDisplay, |
There was a problem hiding this comment.
what's the logic for overriding these two? I don't think it's necessary.
There was a problem hiding this comment.
This was done on the BX so figured it was necessary. If it's not I can remove it
| ...quoteData, | ||
| buyAmountDisplay: isNativeWrapOrUnwrap ? quoteData.buyAmount : quoteData.buyAmountDisplay, | ||
| sellAmountDisplay: isNativeWrapOrUnwrap ? quoteData.sellAmount : quoteData.sellAmountDisplay, | ||
| feeInEth: isNativeWrapOrUnwrap ? '0' : quoteData.feeInEth, |
There was a problem hiding this comment.
Also this. The SDK should handle it internally
There was a problem hiding this comment.
Also brought this over from the BX
brunobar79
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1598
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test