fix estimated fee #5885
fix estimated fee #5885
Conversation
There was a problem hiding this comment.
Added a couple comments and there are conflicts. Once all those are fixed I'd love for @ibrahimtaveras00 to take a look to this one too
| // which is great when refetching for the same chainId, but we don't want to keep the previous data | ||
| // when fetching for a different chainId | ||
| return { | ||
| data: data && data.chainId === chainId ? data.gasLimit : initialData?.gasLimit, |
There was a problem hiding this comment.
leaving a note for the future: when we'd like to upgrade to react-query v5 where we can replace this with using placeholderData which gets access to previous values in v5 (currently it does not, which is why we need to do this particular pattern in order to get previous data while fetching if you stay switch assets while on the same chain)
There was a problem hiding this comment.
RESOLVED:
Blocking PR for now - Finding weirdness in the custom gas panel - confirming if this is also happening in latest develop
Separate issue that is also happening in develop: once you update custom gas and then come back to the panel, tip resets to 0
Uploading Simulator Screen Recording - iPhone 15 Pro - 2024-06-27 at 08.43.01.mp4…
jinchung
force-pushed
the
fix-estimated-fee
branch
from
f23abdb to
a2508e6
Compare
brunobar79
dismissed stale reviews from jinchung and ibrahimtaveras00
Issues resolved
Fixes APP-1556
Fixes APP-1637
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test