claim #5887
Merged
claim #5887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobar79
force-pushed
the
@bruno/points-raps
branch
from
ec9d7fa to
8eb279b
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@rainbow-me/[email protected] |
brunobar79
commented
Jun 23, 2024
| refetch(); | ||
| return { nonce: bridgeNonce }; | ||
| } else { | ||
| setClaimStatus('error'); |
There was a problem hiding this comment.
@christianbaroni I've added this new state error so you can show something specific if bridging fails
jinchung
added a commit
that referenced
this pull request
Jun 24, 2024
* Enable P3 color in RN and gradients * Bump Reanimated, Skia * WIP: new UI * Fix Android build * Android fixes, add placeholder bridge fee labels * Points UI Data (#5876) * feat: insert new points data * feat: claim request * fix: cleanup smooth pager ids * Remove unused imports * Lighten separators in light mode * Fix extra space when Stack children aren't rendered Also makes the leaderboard section spacing consistent with the other sections * Claim flow improvements, card visibility tweaks * Cache remote card images, minor code cleanup * i18n, clean up InfoCard placeholders * Add i18n strings * Clean up InfoCard, notifications toggle styles * Add experimental flag, remote flag * Lower dark mode border opacity * Claim flow improvements, i18n * Hide ClaimCard for watched wallets * Make copy adjustments * Fix wallet list scroll bug This wallet list code needs more significant refactoring, but this fixes the issue that often prevents the wallet list from being scrollable * Clean up light mode styles * Add claim flow spinner, network list cleanup * claim (#5887) * Adjust spinner size, layout * fix claim * Add basic claim error state * Add missing i18n strings * Catch more error cases, use claim error UI instead of alert Replaces the "Unable to load wallet" alert with the claim error state, since the !wallet condition catches non-serious errors like Face ID failures * Speed up wallet switcher, minor code cleanup * Use more saturated green * differentiate errors * Update using default gas limit for bridge quote if it exists * Update default value in experimental config for ETH_REWARDS * Clean up Android claim flow styles * Improve copy * Improve InfoCard copy, styles * Adjust InfoCard copy: Rank → Placed * Add bridge failure error state * Fix bridge-error Done button press handler * Clean up loading skeletons --------- Co-authored-by: Christopher Howard <[email protected]> Co-authored-by: Bruno Barbieri <[email protected]> Co-authored-by: Bruno Barbieri <[email protected]> Co-authored-by: jinchung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
Brought raps from BX and adapted to the app.
Screen recordings / screenshots
Posted on slack
What to test
Claim flow
You can set the flag
DO_FAKE_CLAIMto true and that would let you use the whole flow without doing a real claim so you can try it as many times as you want.If you set it to false, a real claim will be done and you won't be able to do it unless you ask backend to reset the claims to test again with that same wallet