Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase now working on android #5898

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Firebase now working on android #5898

merged 5 commits into from
Jun 27, 2024

Conversation

brunobar79
Copy link
Member

@brunobar79 brunobar79 commented Jun 26, 2024

Fixes APP-####

What changed (plus any additional context for devs)

  • Updated react-native-firebase to the latest version
  • We were missing the SHA1 key on firebase config which caused android to not work in release mode

Screen recordings / screenshots

Screenshot 2024-06-26 at 7 36 40 PM

What to test

First of all, grab the google-services.json file from here https://github.com/rainbow-me/rainbow-env/pull/67

On iOS - create a testflight version and play with the remote config flag debug_iOS on firebase. You should see an alert on launch when the flag is set to true.

On iOS - create an APK in release mode and play with the remote config flag debug_android on firebase. You should see an alert on launch when the flag is set to true.

Once QA approves it, I'll remove the code related to the alert and merge it.

Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now on both OS's ✅

@brunobar79 brunobar79 merged commit 8c87e95 into develop Jun 27, 2024
6 checks passed
@brunobar79 brunobar79 deleted the @bruno/firebase-bump branch June 27, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants