Hook up minimum received and max sold values #5900
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1620
What changed (plus any additional context for devs)
Issues solved:
This PR will require some follow up after launch. We have a few updates that we want to do from the backend, so for now, the minimum received value is hooked up correctly (value after fees and slippage) but the maximum sold amount currently matches the input amount for output-based trades (the most pessimistic/conservative estimate we have.) We'll update this in a later release.
What to test
Test with a variety of input-based vs output-based trades.
Input-based trades should show "Minimum Received" in the review panel with a value that is less than the output amount.
Output-based trades should show "Maximum Sold" in the review panel with a value that matches in the input amount. (This will be updated later)
Screen recordings / screenshots