Debounce fetch quote after updating slippage #5904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1619
What changed (plus any additional context for devs)
Issue: in the Review Panel when you update slippage, it wasn't immediately triggering a quote refetch and would update the minimum received / max sold only at the next interval of fetching.
This triggers a debounced quote refetch on updates to slippage.
What to test
Update slippage in the review panel - you should see the actual quote update as well as the minimum received / maximum sold amount for input-based and output-based trades.
Screen recordings / screenshots
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-29.at.17.28.51.mp4