Fix selected state for network, timeframe, sort #6352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implement gql query to get trending tokens for selected network and display them * fix dragging issue with no chainId and tapping empty space resetting network to all networks * add mock handler for navigating to swaps flow * fix lint * shuffle files and break out network switcher to be composable * refactor SwapCoinIcon to use a size prop instead of small, large, xlarge, etc. * add view token analytics event * add time tracking to discover screen * add tracking for if user has swapped a trending token * decouple network selector from trending tokens and add rest of analytics events * fix customize network banner not being dismissable * revert white color token change
…plementation-phase-1
…thub.com/rainbow-me/rainbow into gregs/app-1958-ui-implementation-phase-1
* remove arrows for price change * fix friend holders display * fix dupes * align and make friends looks better * remove spread * ops --------- Co-authored-by: gregs <[email protected]>
* format price for amounts >1 different than fractal amounts * handle >6 figs native value different and show in compact notation to prevent row collision * prevent token symbol from growing beyond what it needs * Update src/components/Discover/TrendingTokens.tsx * remove DebugLayout
brunobar79
approved these changes
Dec 19, 2024
derHowie
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
looks good, played with settings, and theme in video below
PoW: https://www.loom.com/share/7b4351fe2a16489dbec696dccb148254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-2210
What changed (plus any additional context for devs)
Adds selected state to the network, sort, and timeframe tabs if not on the default option. Also has a bit of clean up with gestures. Adds a little bit of performance improvement to
useTrackDiscoverScreenTimeto only run the useEffect when the DiscoverScreen is detected as the active route instead of always and internally checking that.some minor i18n changes
Screen recordings / screenshots
// wip
What to test
test active states on networks, timeframes, and sort