Use sheet instead of custom AbsolutePortal #6357
Merged
+99
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did it always took this long to open the network switcher after tapping the button? |
just an issue with my dev environment not a problem in prod |
brunobar79
approved these changes
Dec 19, 2024
brunobar79
added a commit
that referenced
this pull request
Dec 19, 2024
* portal * trending tokens * network switcher * feat flag * opss * i18n * performance * ops * Wire up trending tokens UI (#6292) * implement gql query to get trending tokens for selected network and display them * fix dragging issue with no chainId and tapping empty space resetting network to all networks * add mock handler for navigating to swaps flow * fix lint * shuffle files and break out network switcher to be composable * refactor SwapCoinIcon to use a size prop instead of small, large, xlarge, etc. * add view token analytics event * add time tracking to discover screen * add tracking for if user has swapped a trending token * decouple network selector from trending tokens and add rest of analytics events * fix customize network banner not being dismissable * revert white color token change * lint? * add remote config flag for trending tokens * scroll & light mode * better categories colors * fix select all chain badges * polish ui * better buttons * save * align friends pfps * fix price change timeframes * fix images * better currency formatting * fix comment * fix network button selecting the wrong one * fix: tt sort (#6337) * TT fixes (#6338) * remove arrows for price change * fix friend holders display * fix dupes * align and make friends looks better * remove spread * ops --------- Co-authored-by: gregs <[email protected]> * fix: tt -> swaps nav (#6343) * fix missing header height on the sheet (#6315) * convert network accessors to functions (#6219) * convert network accessors to functions * backend networks store * wrote a couple worklet functions to get swaps working * fix other calls * Update package.json * Update ios/Podfile.lock * move all functions into backendNetworksStore and replace calls * refresh podlock * no clue what happened during merge * fix: APP-2021 * fix: APP-2022 * fix build and lint * Bump nanoid from 3.3.7 to 3.3.8 in /src/design-system/docs (#6320) Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.3.7...3.3.8) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update default currentNonce value to -1 (use case: fresh wallet or freshly imported wallet) (#6324) * Set currentNonce default to -1 if not stored (use case: fresh wallet or freshly imported wallet) * Update pending txn logic to treat default of -1 for currentNonce when it does not exist yet * Replace node ack retries with a small delay (#6326) * fix undefined size on TextShadow component when switching themes (#6329) * chore: update swaps sdk + use new getWrappedAssetAddress method (#6327) * NFT checker 2.0 (#6293) * Add inkchain support (#6323) * add basic entries * update chain badge assets * alphabetizing imports / mappings * update tokenSearch, default bips * alphabetize and clean up * alphabetize en_US * add explainer text and colors * update simplehash networks * update chainIds and explainer copy * chain IDs * add proper colors * add badges I have access to * add assets to assets folder as well * add assets * comment out other chains * remove badges for other networks * fix ethereum badge assets * idk if podlock is needed * Readd avalanche network type * Add new chains to chainsIdByNetwork mapping --------- Co-authored-by: Bruno Barbieri <[email protected]> Co-authored-by: jinchung <[email protected]> * Retrieve FID for wallet addresses (#6330) * bump iOS and Android to v1.9.50 (#6340) * Icons hotfix (#6342) * handle raw response from contract call correctly * fix logic to reveal icons * resolve missing imports * chainId * prioritize symbol & not resize selected catergory pill * discorty screen trending tokens separator * add remote config to control limit * remove unused import * chore: temp hc for review at limit 12 * Update iOS and Android to v1.9.51 (#6346) * chore: remove unnecessary hc limit * fix: nav to swap from tt row (#6347) * Fix non fractal price data formatter (#6348) * format price for amounts >1 different than fractal amounts * handle >6 figs native value different and show in compact notation to prevent row collision * prevent token symbol from growing beyond what it needs * Update src/components/Discover/TrendingTokens.tsx * remove DebugLayout * Fix spacing to 28px in latest TestFlight version (#6351) * fix spacing between items * Update src/components/Discover/TrendingTokens.tsx * fix network switcher using name instead of label (#6350) * add default initial pinned chains (#6349) * portal * trending tokens * network switcher * feat flag * opss * i18n * performance * ops * Wire up trending tokens UI (#6292) * implement gql query to get trending tokens for selected network and display them * fix dragging issue with no chainId and tapping empty space resetting network to all networks * add mock handler for navigating to swaps flow * fix lint * shuffle files and break out network switcher to be composable * refactor SwapCoinIcon to use a size prop instead of small, large, xlarge, etc. * add view token analytics event * add time tracking to discover screen * add tracking for if user has swapped a trending token * decouple network selector from trending tokens and add rest of analytics events * fix customize network banner not being dismissable * revert white color token change * lint? * add remote config flag for trending tokens * scroll & light mode * better categories colors * fix select all chain badges * polish ui * better buttons * save * align friends pfps * fix price change timeframes * fix images * better currency formatting * fix comment * fix network button selecting the wrong one * fix: tt sort (#6337) * TT fixes (#6338) * remove arrows for price change * fix friend holders display * fix dupes * align and make friends looks better * remove spread * ops --------- Co-authored-by: gregs <[email protected]> * fix: tt -> swaps nav (#6343) * convert network accessors to functions (#6219) * convert network accessors to functions * backend networks store * wrote a couple worklet functions to get swaps working * fix other calls * Update package.json * Update ios/Podfile.lock * move all functions into backendNetworksStore and replace calls * refresh podlock * no clue what happened during merge * fix: APP-2021 * fix: APP-2022 * fix build and lint * NFT checker 2.0 (#6293) * Icons hotfix (#6342) * handle raw response from contract call correctly * fix logic to reveal icons * resolve missing imports * chainId * prioritize symbol & not resize selected catergory pill * discorty screen trending tokens separator * add remote config to control limit * remove unused import * chore: temp hc for review at limit 12 * chore: remove unnecessary hc limit * Fix non fractal price data formatter (#6348) * format price for amounts >1 different than fractal amounts * handle >6 figs native value different and show in compact notation to prevent row collision * prevent token symbol from growing beyond what it needs * Update src/components/Discover/TrendingTokens.tsx * remove DebugLayout * Fix spacing to 28px in latest TestFlight version (#6351) * fix spacing between items * Update src/components/Discover/TrendingTokens.tsx * fix network switcher using name instead of label (#6350) * add default initial pinned chains (#6349) * fix network switcher to use a network chip when odd number of pinned (#6354) * Use sheet instead of custom AbsolutePortal (#6357) * use sheet instead of absoluteportal * fix timings * add a little delay between transition expanded and collapsed --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Matthew Wall <[email protected]> Co-authored-by: Christopher Howard <[email protected]> Co-authored-by: Bruno Barbieri <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jin <[email protected]> Co-authored-by: Wayne Cheng <[email protected]> Co-authored-by: Bruno Barbieri <[email protected]> Co-authored-by: Ibrahim Taveras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-2213
Fixes APP-2215
What changed (plus any additional context for devs)
Converts the network selector into a sheet instead of a standalone component.
Screen recordings / screenshots
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-19.at.14.57.22.mp4
What to test
functionality still is the same when selecting/deselecting a network