Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default option to dropdown menu for sort #6359

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Dec 20, 2024

Fixes APP-2221

What changed (plus any additional context for devs)

Adds default and active checkmarks in the dropdown menu for sort and timeframe

Screen recordings / screenshots

Screenshot 2024-12-20 at 9 41 01 AM Screenshot 2024-12-20 at 9 40 58 AM Screenshot 2024-12-20 at 9 40 55 AM

What to test

nothing really just make sure no i18n funkiness happens maybe?

Copy link

linear bot commented Dec 20, 2024

@brunobar79 brunobar79 added the release for release blockers and release candidate branches label Dec 20, 2024
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brunobar79
Copy link
Member

Launch in simulator or device for 02d3f68

@brunobar79 brunobar79 merged commit 7b644f3 into develop Dec 20, 2024
7 of 8 checks passed
@brunobar79 brunobar79 deleted the @matthew/APP-2221 branch December 20, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release for release blockers and release candidate branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants