Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT Offers: crash fix #5539

Merged
merged 2 commits into from
Mar 19, 2024
Merged

NFT Offers: crash fix #5539

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c2bc58
fix
benisgold Mar 19, 2024
9eaedf3
revert rename
benisgold Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/analytics/userProperties.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ export interface UserProperties {
// nft offers
nftOffersAmount?: number;
nftOffersUSDValue?: number;
nftOffersMeanOfferVariance?: number;
nftOffersMedianOfferVariance?: number;
nftOffersMedianFloorDifferencePercentage?: number;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if its worth switching these values cause itll mess with the reports we currently have

nftOffersMeanFloorDifferencePercentage?: number;

// mint.fun
numberOfMints?: number;
Expand Down
24 changes: 14 additions & 10 deletions src/resources/reservoir/nftOffersQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,23 +98,27 @@ export function useNFTOffers({ walletAddress }: { walletAddress: string }) {
const offerVarianceArray = nftOffers.map(offer => offer.floorDifferencePercentage / 100);
offerVarianceArray.sort((a, b) => a - b);

// calculate median offer variance
// calculate median floor difference percentage
const middleIndex = Math.floor(offerVarianceArray.length / 2);
let medianVariance;
if (offerVarianceArray.length % 2 === 0) {
medianVariance = (offerVarianceArray[middleIndex - 1] + offerVarianceArray[middleIndex]) / 2;
} else {
medianVariance = offerVarianceArray[middleIndex];
let medianFloorDifferencePercentage;
if (offerVarianceArray.length) {
if (offerVarianceArray.length % 2 === 0) {
medianFloorDifferencePercentage = (offerVarianceArray[middleIndex - 1] + offerVarianceArray[middleIndex]) / 2;
} else {
medianFloorDifferencePercentage = offerVarianceArray[middleIndex];
}
}

// calculate mean offer variance
const meanVariance = offerVarianceArray.reduce((acc, cur) => acc + cur, 0) / offerVarianceArray.length;
// calculate mean floor difference percentage
const meanFloorDifferencePercentage = offerVarianceArray.length
? offerVarianceArray.reduce((acc, cur) => acc + cur, 0) / offerVarianceArray.length
: undefined;

analyticsV2.identify({
nftOffersAmount: nftOffers.length,
nftOffersUSDValue: totalUSDValue,
nftOffersMedianOfferVariance: medianVariance,
nftOffersMeanOfferVariance: meanVariance,
nftOffersMedianFloorDifferencePercentage: medianFloorDifferencePercentage,
nftOffersMeanFloorDifferencePercentage: meanFloorDifferencePercentage,
});
}, [query.data?.nftOffers]);

Expand Down
Loading