Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxFeePerGas = maxBaseFee + maxPriorityFee #5949

Conversation

greg-schrammel
Copy link
Contributor

@greg-schrammel greg-schrammel commented Jul 23, 2024

Fixes APP-####

What changed (plus any additional context for devs)

Screen recordings / screenshots

Screen.Recording.2024-07-24.at.14.47.11.mov

What to test

Copy link
Contributor

@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@jinchung jinchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 - confirming if you tested with a swap from a test wallet, if you can add the recording as PoW

@jinchung jinchung merged commit 3b22a23 into develop Jul 24, 2024
6 checks passed
@jinchung jinchung deleted the gregs/app-1695-swapsbridges-cannot-be-sent-due-to-gas-bug-maxfeepergas branch July 24, 2024 18:13
BrodyHughes pushed a commit that referenced this pull request Jul 25, 2024
(cherry picked from commit 3b22a23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants