Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm catalog protocol support #1451

Open
1 task done
mmellado opened this issue Aug 28, 2024 · 5 comments
Open
1 task done

pnpm catalog protocol support #1451

mmellado opened this issue Aug 28, 2024 · 5 comments

Comments

@mmellado
Copy link

Note

This is more of a feature request to support the new pnpm catalogs feature, which is a new way to specify dependency versions


Steps to Reproduce

run ncu

Current Behavior

Dependencies listed under the catalog key in pnpm-workspace.yaml are ignored

Expected Behavior

Account for, list, and provide the option to udpate catalog versions listed in pnpm-workspace.yaml

@TylerNRobertson
Copy link

Would be great to see this added!

@hilja
Copy link

hilja commented Feb 3, 2025

Btw, renovate catalog implementation renovatebot/renovate#33376

@fpapado
Copy link

fpapado commented Feb 4, 2025

Heya 👋 I implemented catalogs support in Renovate. I would be happy to contribute support for catalogs in ncu, if the maintainers think this is worthwhile.

I tried to look through the contribution guide and other issues, to understand the process and avoid stepping on anyone's toes, if they have started working on it. I didn't find any assignees, so I will wait for a bit and pick this up next week.

I might have some nitty-gritty questions about supporting package files aside from package.json (since catalogs use pnpm-workspace.yaml). I can put those in a draft PR if you prefer 😌

@raineorshine
Copy link
Owner

Adding support for the catalog: protocol would be a welcome feature. It does not increase the complexity of the tool or the surface area of the API, so it fits within npm-check-updates' design philosophy. And the upvotes indicate that this would be helpful to many. I would be happy to provide guidance on where things are in the codebase.

FYI Workspace packages are read in from pnpm-workspace.yaml in getAllPackages and pnpm workspace unit tests are in workspace.test.ts.

@fpapado
Copy link

fpapado commented Feb 4, 2025

Thank you kindly for the context and the practical info! I'll take this to my to-do list then 🗒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants