Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent favicon rendering (on server settings but not on homepage and collections etc) #102

Closed
rairprotocol opened this issue Jul 9, 2024 · 3 comments · Fixed by #131
Closed

Inconsistent favicon rendering (on server settings but not on homepage and collections etc) #102

rairprotocol opened this issue Jul 9, 2024 · 3 comments · Fixed by #131
Assignees
@SeanM322
Labels
backend (bug) Something isn't working frontend (bug) relates to rair-front system
Milestone
Front/Back + Devo...

Comments

@rairprotocol
Copy link
Collaborator

Check favicon rendering
@rairprotocol rairprotocol added backend (bug) Something isn't working frontend (bug) relates to rair-front system labels Jul 9, 2024
@SeanM322
Copy link
Collaborator

I think it's also related to this ticket #96
check my comment

@SeanM322 SeanM322 moved this from Todo to QA Ready in @rairprotocol's rair-dapp Jul 10, 2024
@sarora180673 sarora180673 moved this from QA Ready to Todo in @rairprotocol's rair-dapp Jul 10, 2024
@rairprotocol
Copy link
Collaborator Author

Replace R favicon with default loading favicon.

Replace default rair protocol image with loading image.

Bigger issue is to investigate the path loading flows for favicon from backend. On f5 refresh favicons work - but on navigation it doesn't

@rairprotocol
Copy link
Collaborator Author

provide new non R default favicon for index.html - pick from here :) https://changelog.com/news/a-collection-of-free-svg-loading-spinners-AX0y

@SeanM322 SeanM322 linked a pull request Jul 22, 2024 that will close this issue
Set default loading favicon #131
Merged
@sarora180673 sarora180673 moved this from Todo to Done in @rairprotocol's rair-dapp Jul 23, 2024
@sarora180673 sarora180673 closed this as completed by moving to Done in @rairprotocol's rair-dapp Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SeanM322 SeanM322

Labels
backend (bug) Something isn't working frontend (bug) relates to rair-front system
Projects
@rairprotocol's rair-dapp
Status: Done
Milestone
Front/Back + Devops Performance!
Development

Successfully merging a pull request may close this issue.

Set default loading favicon rairprotocol/rair-dapp
2 participants
@sarora180673 @SeanM322