Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency org.springframework.boot:spring-boot-starter-parent to v3.4.0 #898

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 22, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.springframework.boot:spring-boot-starter-parent (source) 3.3.6 -> 3.4.0 age adoption passing confidence

Release Notes

spring-projects/spring-boot (org.springframework.boot:spring-boot-starter-parent)

v3.4.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled because a matching PR was automerged previously.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Contributor

coderabbitai bot commented Nov 22, 2024

Walkthrough

The changes in this pull request involve modifications to the configuration and testing of the order service application. The main method in TestOrderServiceApplication has been updated to utilize the withAdditionalProfiles method for setting Spring profiles. The ContainersConfig class has been adjusted to import a new KafkaContainer class and use a different Docker image. Additionally, the OrderControllerTest class has transitioned from using @MockBean to @MockitoBean for mock dependencies, enhancing the testing framework's integration.

Changes

File Path Change Summary
order-service/src/test/java/com/example/orderservice/TestOrderServiceApplication.java Updated main method to use withAdditionalProfiles instead of setting system property for Spring profile.
order-service/src/test/java/com/example/orderservice/common/ContainersConfig.java Changed import for KafkaContainer, updated Docker image from confluentinc/cp-kafka:7.7.1 to apache/kafka-native:3.8.1, and removed withKraft() method call.
order-service/src/test/java/com/example/orderservice/web/controllers/OrderControllerTest.java Replaced @MockBean annotations with @MockitoBean for OrderService, OrderGeneratorService, and OrderKafkaStreamService.

Possibly related PRs

  • feat : upgrade to spring boot 3.4.x #870: This PR modifies the TestOrderServiceApplication class, including changes to the main method that align with the profile configuration changes made in the main PR.
  • feat : apply best practices #829: This PR updates the getOrderRequest method in the TestData class, which is related to the order service, indicating a potential connection to the changes in the main PR regarding order processing.
  • revert : upgrade to spring boot 2.4.0 #888: This PR reverts changes in the TestOrderServiceApplication class that affect the profile configuration, directly relating to the modifications made in the main PR.

🐇 In the code we hop and play,
New profiles guide our way.
Kafka's image, fresh and bright,
Mockito's beans now feel just right.
Testing flows with joyful cheer,
Order service, we hold dear! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bdb512b and 59ba09f.

⛔ Files ignored due to path filters (1)
  • order-service/pom.xml is excluded by !**/*.xml
📒 Files selected for processing (3)
  • order-service/src/test/java/com/example/orderservice/TestOrderServiceApplication.java (1 hunks)
  • order-service/src/test/java/com/example/orderservice/common/ContainersConfig.java (2 hunks)
  • order-service/src/test/java/com/example/orderservice/web/controllers/OrderControllerTest.java (2 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor Author

renovate bot commented Dec 12, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@rajadilipkolli
Copy link
Owner

@coderabbitai full review

Copy link
Contributor

coderabbitai bot commented Dec 12, 2024

✅ Actions performed

Full review triggered.

@rajadilipkolli rajadilipkolli merged commit 1196f59 into main Dec 12, 2024
7 of 8 checks passed
@rajadilipkolli rajadilipkolli deleted the renovate/spring-boot branch December 12, 2024 13:34
Copy link

Qodana Community for JVM

31 new problems were found

Inspection name Severity Problems
Usage of API marked for removal 🔴 Failure 8
@NotNull/@Nullable problems 🔶 Warning 6
Redundant 'if' statement 🔶 Warning 4
Unnecessary conversion to 'String' 🔶 Warning 3
Unchecked warning 🔶 Warning 2
Duplicate throws 🔶 Warning 1
Redundant type cast 🔶 Warning 1
Method can be extracted ◽️ Notice 4
Non-distinguishable logging calls ◽️ Notice 2

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant