Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncatchable exception in SMS-HTTP #10

Open
GoogleCodeExporter opened this issue Aug 21, 2015 · 3 comments
Open

Uncatchable exception in SMS-HTTP #10

GoogleCodeExporter opened this issue Aug 21, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

In the class SmsSendHandler in the sms-http module, if an incorrect response is 
returned from the HTTP request, the module throws an 
SmsDeliveryFailureException. However, this is uncatchable by implementers and 
is not handled anywhere in the platform or sms-http module. Sms-http listens on 
SEND_SMS events. An implementer calls the service provided by the sms-api 
module, which raises the SEND_SMS event and that is shuttled to a JMS queue 
which is sent back in to the ServerEventRelay, so the implementer is unable to 
access exceptions the http module throws. An alternative would be to raise a 
new event indicating the response was incorrect.

Original issue reported on code.google.com by [email protected] on 1 Feb 2012 at 8:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant