Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework rakugo parser #84 #118

Merged
merged 7 commits into from
Jun 14, 2022
Merged

Rework rakugo parser #84 #118

merged 7 commits into from
Jun 14, 2022

Conversation

theludovyc
Copy link
Collaborator

@theludovyc theludovyc commented Jun 14, 2022 •
edited
Loading

Fix #84 🥳

Need to reopen #84 after merge to do parse_scripts(folder_path:String) <= parse all rk files in folder at path and store them.

@Jeremi360 Jeremi360 merged commit 129414f into rakugoteam:1.0 Jun 14, 2022
@Jeremi360 Jeremi360 mentioned this pull request Jun 14, 2022
Open
@theludovyc theludovyc deleted the ReworkRakugoParser#84 branch June 17, 2022 17:18
@theludovyc theludovyc added the majorChange Add this pr to changelog and should describe it label Jun 26, 2022
@theludovyc theludovyc changed the title Rework rakugo parser#84 Rework rakugo parser #84 Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
majorChange Add this pr to changelog and should describe it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rework Rakugo/Parser, parse_scripts(folder_path:String)
2 participants
@theludovyc @Jeremi360