Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer possible to use a non-TLS connection with Twisted 19.7.0+ #28

Open
Juhaz opened this issue Sep 19, 2019 · 3 comments · May be fixed by #29
Open

No longer possible to use a non-TLS connection with Twisted 19.7.0+ #28

Juhaz opened this issue Sep 19, 2019 · 3 comments · May be fixed by #29

Comments

@Juhaz
Copy link

Juhaz commented Sep 19, 2019

As of Twisted 19.7.0, xmlstream.TLSInitiatingInitializer is required by default (as I'm sure you know since you pushed the changes yourself)

Unfortunately Wokkel doesn't expose the functionality in XMPPClient so it's no longer possible to make non-TLS connections at all.

Juhaz pushed a commit to Juhaz/wokkel that referenced this issue Sep 19, 2019
xmlstream.TLSInitiatingInitializer through XMPPClient.
Fixes: ralphm#28
@ralphm
Copy link
Owner

ralphm commented May 24, 2021

@Juhaz: looking into this, I seem to remember that was more or less intentional. In what circumstances would it be reasonable to have XMPPClient not use TLS?

@Juhaz
Copy link
Author

Juhaz commented May 24, 2021

@ralphm we are running a bunch of microservices that are perhaps semantically more like components than "normal" clients but for one reason or another didn't quite fit that mold either. They're running in same internal network as the XMPP server itself so TLS is necessary or helpful.

I understand that this is probably not a very common use-case.

@ralphm
Copy link
Owner

ralphm commented May 24, 2021

I guess the use-case itself is not that uncommon. However, for a while now, best practice is to have interconnecting (micro)services use transport encryption. Usually for regulatory compliance and privacy reasons. So I assumed nobody really did that anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants