Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve python utils #74

Merged
merged 35 commits into from
Jun 12, 2024
Merged

Improve python utils #74

merged 35 commits into from
Jun 12, 2024

Conversation

BAILOOL
Copy link
Collaborator

@BAILOOL BAILOOL commented May 26, 2024 •
edited
Loading

Improving python utils scripts.

TODOs:

  • Linters: isort, black
  • mypy and pylint and fix errors
  • argparse for scripts arguments
  • save outputs to disk if screen is not available
  • update docker images
  • add python linters test to CI
  • single script to run python utils after the calibration
  • add example of each script's outputs to README
  • add python utils run to CI and download results
  • update Contributions guide

Close #73

@BAILOOL BAILOOL added the documentation Improvements or additions to documentation label May 26, 2024
@BAILOOL BAILOOL self-assigned this May 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 26, 2024 •
edited
Loading

LCOV of commit 5e28b01 during CI #162

Summary coverage rate:
  lines......: 83.0% (2937 of 3538 lines)
  functions..: 90.5% (248 of 274 functions)
  branches...: no data found

Files changed coverage rate: n/a

BAILOOL added 25 commits May 27, 2024 23:09
@BAILOOL BAILOOL requested a review from rameau-fr June 10, 2024 21:02
@BAILOOL BAILOOL marked this pull request as ready for review June 11, 2024 22:00
rameau-fr
rameau-fr approved these changes Jun 12, 2024
View reviewed changes
Copy link
Owner

@rameau-fr rameau-fr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me!

@BAILOOL BAILOOL merged commit b213379 into master Jun 12, 2024
9 checks passed
@BAILOOL BAILOOL deleted the feature/improve-python-utils branch June 12, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rameau-fr rameau-fr rameau-fr approved these changes

Assignees

@BAILOOL BAILOOL

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

main_display_cam_obj_pose.py error
2 participants
@BAILOOL @rameau-fr