Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting multiple versions of JS libraries #343

Open
jrowen opened this issue Jul 18, 2019 · 4 comments
Open

Supporting multiple versions of JS libraries #343

jrowen opened this issue Jul 18, 2019 · 4 comments

Comments

@jrowen
Copy link

jrowen commented Jul 18, 2019

Is it possible to support multiple versions of JS dependencies with htmlwidgets?

Due to a recent licensing change with handsontable, we're exploring whether rhandsontable could be updated to support different versions of the handsontable JS library (more info here).

@ramnathv
Copy link
Owner

@jrowen One way to make this work is to NOT use YAML for specifying dependencies and instead use an R function that can accept the version of handsontable as an option. @timelyportfolio is the expert on this and can provide you with a concrete example of how to do this. Hope this helps.

@timelyportfolio
Copy link
Collaborator

Happy to help and actually can benefit from this in rhandsontable. I will comment, demonstrate, and likely submit pull on the repo. We will likely want to limit number of js versions to keep package size down.

@jrowen
Copy link
Author

jrowen commented Jul 18, 2019

That sounds great! @trshafer has started a similar PR, so there may be an opportunity to collaborate. Thanks.

@ramnathv
Copy link
Owner

@timelyportfolio One thought is NOT to ship all versions with the package, but make available a function that can download a specific version that is supported. The download location needs to be standardized, but this will have the advantage of keeping the package lean. Thanks for the help BTW! cc @jrowen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants