updated bookValue to be TangibleBookValue #1783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retroactively change bookValue from bookValuePerShare to TangibleBookValue from get_balance_sheet() and changed original bookValue to bookValuePerShare
ValueRaider
reviewed
Dec 13, 2023
| @@ -1751,6 +1751,9 @@ def get_mutualfund_holders(self, proxy=None, as_dict=False): | |||
| def get_info(self, proxy=None) -> dict: | |||
| self._quote.proxy = proxy or self.proxy | |||
| data = self._quote.info | |||
| data['bookValuePerShare'] = data['bookValue'] | |||
| bal_sheet = self.get_balance_sheet() | |||
There was a problem hiding this comment.
I don't like this, introduces another GET request. Most people fetching info don't want book value - let those that do directly request balance sheet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #936 by retroactively changing
bookValuefrom book value per share toTangibleBookValuefromget_balance_sheet()and changed originalbookValuetobookValuePerShare