Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue3 Migration tool adds incorrect annotation, blocking app from loading #12655

Closed
richard-cox opened this issue Nov 21, 2024 · 1 comment · Fixed by #12665
Closed

Vue3 Migration tool adds incorrect annotation, blocking app from loading #12655

richard-cox opened this issue Nov 21, 2024 · 1 comment · Fixed by #12665
Assignees
@aalves08
Labels
area/extensions kind/bug QA/None size/0.5 Size Estimate 0.5
Milestone
v2.11.0

Comments

@richard-cox
Copy link
Member

Setup

  • Rancher version: 2.10.0

Describe the bug

  • Using the migration tool will update the extensions package.json annotations
  • However it uses the wrong value, which means the dashboard will ignore it and assume the extension is not compatible with vue3 world
    • Adds catalog.cattle.io/ui-extension-version
    • Should add catalog.cattle.io/ui-extensions-version
    • See creators/extension/migrate/tasks/packageUpdates.js

To Reproduce

Result

  • pkg//package.json contains incorrect annotation catalog.cattle.io/ui-extension-version

Expected Result

  • pkg//package.json contains incorrect annotation catalog.cattle.io/ui-extensions-version
@richard-cox richard-cox added this to the v2.10.1 milestone Nov 21, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Nov 21, 2024
@aalves08 aalves08 added to-triage-exts-P0-P1 QA/None and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Nov 25, 2024
@aalves08 aalves08 self-assigned this Nov 25, 2024
@aalves08 aalves08 added the size/0.5 Size Estimate 0.5 label Nov 25, 2024
@aalves08 aalves08 modified the milestones: v2.10.1, v2.11.0 Nov 25, 2024
@aalves08
Copy link
Member

updated milestone because this need to go into master

@aalves08 aalves08 mentioned this issue Nov 25, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aalves08 aalves08

Labels
area/extensions kind/bug QA/None size/0.5 Size Estimate 0.5
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging a pull request may close this issue.

fix typo in annotation name aalves08/dashboard
2 participants
@richard-cox @aalves08