Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify handling of GitRepo status resources #13243

Closed
aruiz14 opened this issue Jan 30, 2025 · 1 comment · Fixed by #13244
Closed

Simplify handling of GitRepo status resources #13243

aruiz14 opened this issue Jan 30, 2025 · 1 comment · Fixed by #13244
Assignees
Labels
area/fleet area/performance kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@aruiz14
Copy link
Contributor

aruiz14 commented Jan 30, 2025

Is your feature request related to a problem? Please describe.
Up to now, Fleet GitRepo status contained only partial information, which required the UI to perform additional calculation (including iterate over BundleDeployments) in order to obtain a list of resources for a GitRepo.

Describe the solution you'd like
rancher/fleet#3186 is evolving the GitRepo status schema in order to contain the necessary information. From the dashboard's perspective, it's not a breaking, since the field being changed is not consumed at the moment. However, we can take the chance to reduce the mentioned calculations and just consume the new status field.

Describe alternatives you've considered
The future server-side pagination will also allow to improve the performance even further, but these changes will only make adoption easier.

Additional context
This is the final step after multiple recent refactoring with the goal of improving the performance of this UI section:

@aruiz14 aruiz14 self-assigned this Jan 30, 2025
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Jan 30, 2025
@aruiz14 aruiz14 added this to the v2.11.0 milestone Jan 30, 2025
@yonasberhe23
Copy link
Contributor

unit tests adequately cover this update. No manual validation is required. Closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fleet area/performance kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants