Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.3.x] Charts: always use camelCase for values #508

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

fgiudici
Copy link
Member

@fgiudici fgiudici commented Aug 30, 2023

backport of #507 #510

registry_url slipped in

Fixes commit #742b414ba326ae78a30dea4849aa71c478a70d4c

Signed-off-by: Francesco Giudici <[email protected]>
(cherry picked from commit 1409e03)
@fgiudici fgiudici requested a review from a team as a code owner August 30, 2023 14:40
@github-actions github-actions bot added the area/build build related changes label Aug 30, 2023
@fgiudici fgiudici changed the base branch from main to v1.3.x August 30, 2023 14:44
@fgiudici fgiudici self-assigned this Aug 30, 2023
Copy link
Contributor

@frelon frelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgiudici fgiudici added the status/do not merge Do not merge! label Aug 31, 2023
@fgiudici fgiudici marked this pull request as draft August 31, 2023 08:17
fixes #1409e0385fba6d2a9392210b6bbc5760ee09bfe7

Signed-off-by: Francesco Giudici <[email protected]>
(cherry picked from commit 58951cc)
@fgiudici fgiudici removed the status/do not merge Do not merge! label Aug 31, 2023
@fgiudici fgiudici marked this pull request as ready for review August 31, 2023 10:22
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v1.3.x@71aeacb). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             v1.3.x     #508   +/-   ##
=========================================
  Coverage          ?   51.50%           
=========================================
  Files             ?       41           
  Lines             ?     5551           
  Branches          ?        0           
=========================================
  Hits              ?     2859           
  Misses            ?     2443           
  Partials          ?      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidcassany davidcassany merged commit 192dc33 into rancher:v1.3.x Aug 31, 2023
13 checks passed
@fgiudici fgiudici deleted the v1.3.x branch September 1, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build build related changes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants