Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to v1.5.x #777

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

davidcassany
Copy link
Contributor

Backport fixes related to #766

Partial backport from 7227947

Signed-off-by: David Cassany <[email protected]>
@davidcassany davidcassany requested a review from a team as a code owner June 21, 2024 15:06
@github-actions github-actions bot added the area/tests test related changes label Jun 21, 2024
Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞🏻

Backport from 61e76e2

Signed-off-by: David Cassany <[email protected]>
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (v1.5.x@32f3585). Learn more about missing BASE report.

Files Patch % Lines
controllers/managedosversionchannel_controller.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             v1.5.x     #777   +/-   ##
=========================================
  Coverage          ?   54.88%           
=========================================
  Files             ?       40           
  Lines             ?     5014           
  Branches          ?        0           
=========================================
  Hits              ?     2752           
  Misses            ?     1971           
  Partials          ?      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidcassany davidcassany merged commit afcdf10 into rancher:v1.5.x Jun 25, 2024
10 of 11 checks passed
@davidcassany davidcassany deleted the backport_to_v1.5.x branch June 25, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests test related changes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants