Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle to automatically delete no longer in sync versions #780

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

anmazzotti
Copy link
Contributor

Part of #759

This introduces an option to automatically delete ManagedOSVersions that are no longer in sync with a channel.

The default value is false to not change the current behavior, but we can rethink it. It should be safe to enable it by default, in conjunction with #775, but it may still be unexpected for the user.

@anmazzotti anmazzotti requested a review from a team as a code owner June 24, 2024 09:55
@anmazzotti anmazzotti self-assigned this Jun 24, 2024
@github-actions github-actions bot added area/tests test related changes area/build build related changes labels Jun 24, 2024
@anmazzotti anmazzotti force-pushed the add_autocleaning_channel_toggle branch from 9b95ecc to 2dddb2b Compare June 24, 2024 12:39
Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anmazzotti anmazzotti merged commit d07b4f5 into rancher:main Jun 25, 2024
22 checks passed
anmazzotti added a commit to anmazzotti/elemental-operator that referenced this pull request Jun 26, 2024
anmazzotti added a commit that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build build related changes area/tests test related changes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants