Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.6.x] Add toggle to automatically delete no longer in sync versions (#780) #783

Merged

Conversation

anmazzotti
Copy link
Contributor

Backport of #780

@anmazzotti anmazzotti requested a review from a team as a code owner June 26, 2024 10:32
@anmazzotti anmazzotti self-assigned this Jun 26, 2024
@github-actions github-actions bot added area/tests test related changes area/build build related changes labels Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (v1.6.x@d745f7d). Learn more about missing BASE report.

Files Patch % Lines
controllers/managedosversionchannel_controller.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             v1.6.x     #783   +/-   ##
=========================================
  Coverage          ?   57.53%           
=========================================
  Files             ?       41           
  Lines             ?     5103           
  Branches          ?        0           
=========================================
  Hits              ?     2936           
  Misses            ?     1854           
  Partials          ?      313           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anmazzotti anmazzotti merged commit 7fece7e into rancher:v1.6.x Jun 27, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build build related changes area/tests test related changes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants