Skip to content

Commit

Permalink
Remove e2e "difficult" label
Browse files Browse the repository at this point in the history
All tests in multi-cluster are difficult
  • Loading branch information
manno committed Jul 10, 2024
1 parent 77e17cd commit e82ce99
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
4 changes: 3 additions & 1 deletion e2e/multi-cluster/bundle_namespace_mapping_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ import (
"github.com/rancher/fleet/e2e/testenv/kubectl"
)

var _ = Describe("Bundle Namespace Mapping", Label("difficult"), func() {
// This test uses two clusters to demonstrate matching clusters in different
// namespaces. Therefore it's setup and input configuration is difficult.
var _ = Describe("Bundle Namespace Mapping", func() {
var (
k kubectl.Command
kd kubectl.Command
Expand Down
2 changes: 1 addition & 1 deletion e2e/multi-cluster/depends_on_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
fleet "github.com/rancher/fleet/pkg/apis/fleet.cattle.io/v1alpha1"
)

var _ = Describe("Bundle Depends On", Label("difficult"), func() {
var _ = Describe("Bundle Depends On", func() {
var (
k kubectl.Command

Expand Down
3 changes: 2 additions & 1 deletion internal/cmd/cli/apply/apply.go
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,8 @@ func Dir(ctx context.Context, client Getter, name, baseDir string, opts *Options
if opts == nil {
opts = &Options{}
}
// the bundleID is a valid helm release name, it's used as a default if a release name is not specified in helm options
// The bundleID is a valid helm release name, it's used as a default if a release name is not specified in helm options.
// It's also used to create the bundle name.
bundleID := filepath.Join(name, baseDir)
bundleID = name2.HelmReleaseName(bundleID)

Expand Down

0 comments on commit e82ce99

Please sign in to comment.