Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SURE-8809] Fleet deployment fails when Helm chart repo uses custom CA / missing error #2750

Open
kkaempf opened this issue Aug 16, 2024 · 2 comments
Labels
Milestone

Comments

@kkaempf
Copy link
Collaborator

kkaempf commented Aug 16, 2024

SURE-8809

Issue description:

When
adding a git repo to fleet that has a fleet.yaml referencing an external helm chart.

and

the server serving the helm chart uses a custom CA

Then

the Git Repo is added and marked with State "active"

the "Clusters Ready" status remains on "0/0" indefinitely

no error is thrown or visible in the Fleet UI

Expected behavior:

  1. Fleet should honor the custom CA configured in the Rancher global settings or the custom CA configured in the GitRepo resource (spec.CaBundle) when downloading resources, such as Helm charts.

  2. Fleet should display an error message in the UI, indicating that there was a problem downloading the Helm chart

Business impact:

Customer can't use any helm charts from internet sources, because their corporate firewall performs TLS inception, replacing all SSL certs with their own CA.

@kkaempf kkaempf added this to the v2.10.0 milestone Aug 16, 2024
@kkaempf kkaempf added this to Fleet Aug 16, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Fleet Aug 16, 2024
@kkaempf kkaempf changed the title [SURE-8809] we should wait with this until Rancher has an OCI server included. [SURE-8809] Fleet deployment fails when Helm chart repo uses custom CA / missing error Aug 20, 2024
@manno
Copy link
Member

manno commented Aug 20, 2024

We should add support to Fleet to fall back to a default value, unless overridden in the resource.
This is most likely a Fleet install option, I think Fleet already gets re-installed when the Rancher CA changes.

However there are multiple clients in Fleet, which would need to support this. They all use a PEM block for CA in their spec instead.
Specifying the CA in the resource directly has the advantage that we don't need to watch another resource for changes, e.g. to redeploy on certificate rotation. That's not possible, when we rely on a global setting.
Does re-installing Fleet re-render all bundles with the new CA, or do we need to implement this?

  • git monitor (lsremote)
  • git cloner
  • chart downloader
  • image scan (no custom CA yet)

@kkaempf kkaempf added the JIRA Must shout label Aug 21, 2024
@marthydavid
Copy link

I've faced the same issue.

@manno manno modified the milestones: v2.10.0, v2.11.0 Oct 23, 2024
@manno manno moved this from To Triage to 📋 Backlog in Fleet Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants