You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When configuring a webhook with a secret it is not checked when the k8s secret is not created in the cluster.
When the user creates the secret in the cluster the next time the webhook is called it DOES check for the secret.
This is because in the code it is creating the webhook checker with secret based on secret events.
As the secret is not created and does not exist, there is no event and the webhook checker is created without any secret at all.
Expected Behavior
Secret should be checked (when it is configured in the webhook) no matter if the cluster secret is created after/before or not created at all.
Steps To Reproduce
Configure a webhook with a secret in Github.
Trigger the webhook.
Fleet will accept the payload without checking the secret at all.
The text was updated successfully, but these errors were encountered:
weyfonk
changed the title
webhook secret is not checked when k8s secret is not creataed
webhook secret is not checked when k8s secret is not created
Aug 27, 2024
Is there an existing issue for this?
Current Behavior
When configuring a webhook with a secret it is not checked when the k8s secret is not created in the cluster.
When the user creates the secret in the cluster the next time the webhook is called it DOES check for the secret.
This is because in the code it is creating the webhook checker with secret based on secret events.
As the secret is not created and does not exist, there is no event and the webhook checker is created without any secret at all.
Expected Behavior
Secret should be checked (when it is configured in the webhook) no matter if the cluster secret is created after/before or not created at all.
Steps To Reproduce
The text was updated successfully, but these errors were encountered: