Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SURE-8993] CABundle secret not created for gitjob #2824

Closed
1 task done
sebastienmusso opened this issue Sep 11, 2024 · 4 comments
Closed
1 task done

[SURE-8993] CABundle secret not created for gitjob #2824

sebastienmusso opened this issue Sep 11, 2024 · 4 comments

Comments

@sebastienmusso
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When create a gitrepo with CABundle string, git-sync job is created with an extra volume secret wich does not exist.
The init container remain in pending state because of the missing secret

Expected Behavior

When a gitrepo is created with CABundle spec field, the secret with gitrepoName-cabundle have to be created

Steps To Reproduce

  • Architecture: amd64
  • Fleet Version: v0.10.1
  • Cluster:
    • Provider: rke2
    • Options: none
    • Kubernetes Version: v1.28.11+rke2r1

install fleet v0.10.1, create gitrepo with caBundle spec field set.
Wait gitsync pod de start

Environment

- Architecture:
- Fleet Version:
- Cluster:
  - Provider:
  - Options:
  - Kubernetes Version:

Logs

No response

Anything else?

No response

@rancherbot rancherbot added this to Fleet Sep 11, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Fleet Sep 11, 2024
@manno manno added the JIRA Must shout label Sep 11, 2024
@manno manno changed the title CABundle secret not created for gitjob [SURE-8993] CABundle secret not created for gitjob Sep 11, 2024
@manno manno moved this from 🆕 New to 👀 In review in Fleet Sep 11, 2024
@manno manno added this to the v2.9.2 milestone Sep 11, 2024
@manno manno modified the milestones: v2.9.2, v2.10.0 Sep 11, 2024
@manno
Copy link
Member

manno commented Sep 11, 2024

An integration test would be helpful, to make sure this stays in place.

@weyfonk weyfonk moved this from 📋 Backlog to 🏗 In progress in Fleet Sep 13, 2024
@weyfonk weyfonk self-assigned this Sep 13, 2024
@weyfonk weyfonk moved this from 🏗 In progress to 👀 In review in Fleet Sep 13, 2024
@weyfonk weyfonk moved this from 👀 In review to Needs QA review in Fleet Sep 17, 2024
@weyfonk
Copy link
Contributor

weyfonk commented Sep 17, 2024

Additional QA

See this comment

@kkaempf
Copy link
Collaborator

kkaempf commented Sep 18, 2024

@manno shouldn't this be targeting 2.9.x instead ?
#2829 ftw !

@mmartin24 mmartin24 self-assigned this Oct 23, 2024
@mmartin24
Copy link
Collaborator

Verified in v2.10-fe49760f4e50d0b78ca0102c8475bc93361336b0-head with fleet:105.0.0+up0.11.0-beta.3

  • ca-bundle secret IS created when TLS cert is added
  • ca-bundle secret IS NOT created when TLS cert is not added

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants