Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MaxConcurrentReconciles configurable for Agents #2915

Open
manno opened this issue Sep 30, 2024 · 1 comment
Open

Make MaxConcurrentReconciles configurable for Agents #2915

manno opened this issue Sep 30, 2024 · 1 comment

Comments

@manno
Copy link
Member

manno commented Sep 30, 2024

Currently it's possible to configure the maximum number of reconciles (workers) for some controllers.

It should also be possible to configure it for these controller:

  • the agent
  • imagescan
  • cluster
  • clustergroup

What are good defaults? A value of 1 will process events in sequence and avoid conflicts when updating resources. The wrangler-based implementation used 50, however it's unclear if queues behave the same. How do the operators behave with e.g. 2000 goroutines per reconciler? To which degree does it affect memory consumption?

see https://github.com/rancher/fleet/pull/2897/files

@manno manno added this to Fleet Sep 30, 2024
@manno manno converted this from a draft issue Sep 30, 2024
@manno manno added this to the v2.10.0 milestone Sep 30, 2024
@manno manno changed the title Make MaxReconcile configurable for Agents Make MaxConcurrentReconciles configurable for Agents Sep 30, 2024
@manno manno modified the milestones: v2.10.0, v2.10.1 Oct 23, 2024
@weyfonk weyfonk self-assigned this Nov 25, 2024
@weyfonk weyfonk moved this from 📋 Backlog to 🏗 In progress in Fleet Nov 25, 2024
@weyfonk weyfonk moved this from 🏗 In progress to 👀 In review in Fleet Nov 25, 2024
@weyfonk
Copy link
Contributor

weyfonk commented Nov 26, 2024

  • Backport to v0.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

No branches or pull requests

2 participants