Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverrideTargets and clustersDesiredReady Count mismatch #2995

Open
2 tasks
manno opened this issue Oct 24, 2024 · 0 comments
Open
2 tasks

OverrideTargets and clustersDesiredReady Count mismatch #2995

manno opened this issue Oct 24, 2024 · 0 comments

Comments

@manno
Copy link
Member

manno commented Oct 24, 2024

Could be related to rancher/dashboard#12232, rancher/rancher#46916, rancher/dashboard#11643

The calculation of gitrepo status fields has several problems:

It seems the clustersDesiredReady count does not work with the overrideTargets option. The result is set in the gitrepo.Status.DesiredReadyClusters.

Furthermore, the gitops controller, does not trigger for bundledeployment changes, but the resourceKey and "Bundle" condition are computed from bundledeployments. The "Bundle" condition contains gitrepo.Status.Summary, which consists of the ready and desiredReady for bundledeployments. The code assumes a bundle always changes after a bundledeployment changes and triggers the status update code that way.

The original JIRA issue SURE-9111 has been resolved.

This can be worked on after #3186

  • Investigate if overrideTargets is reflected in the resource counts correctly
  • Add a test if needed
@manno manno added this to Fleet Oct 24, 2024
@manno manno converted this from a draft issue Oct 24, 2024
@manno manno added kind/bug JIRA Must shout labels Oct 24, 2024
@manno manno changed the title OverrideTargets and clustersDesiredReady Count mismatch [SURE-9111] OverrideTargets and clustersDesiredReady Count mismatch Oct 24, 2024
@manno manno self-assigned this Oct 24, 2024
@manno manno removed their assignment Dec 19, 2024
@kkaempf kkaempf added this to the v2.9.6 milestone Dec 19, 2024
@manno manno moved this from 🏗 In progress to 📋 Backlog in Fleet Dec 19, 2024
@manno manno changed the title [SURE-9111] OverrideTargets and clustersDesiredReady Count mismatch OverrideTargets and clustersDesiredReady Count mismatch Dec 19, 2024
@manno manno removed the JIRA Must shout label Dec 19, 2024
@manno manno modified the milestones: v2.9.6, v2.11.0 Dec 19, 2024
@manno manno modified the milestones: v2.9.6, v2.11.0, v2.11.1 Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants