Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit directory-to-bundle logic #3101

Open
2 tasks
weyfonk opened this issue Nov 26, 2024 · 0 comments
Open
2 tasks

Revisit directory-to-bundle logic #3101

weyfonk opened this issue Nov 26, 2024 · 0 comments

Comments

@weyfonk
Copy link
Contributor

weyfonk commented Nov 26, 2024

While looking at this code and that one in the context of reading directories for determining which ones to create bundles from, it seems that we could probably simplify some of this logic:

  • this seems to browse each subdirectory multiple times, once from the filepath.Walk loop and once from shouldCreateBundleFromThisPath logic. Can we do better?
  • consider using WalkDir, supposedly more efficient than Walk.

Related to this comment.

@rancherbot rancherbot added this to Fleet Nov 26, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Fleet Nov 26, 2024
@kkaempf kkaempf added this to the v2.11.0 milestone Nov 26, 2024
@manno manno moved this from 🆕 New to 📋 Backlog in Fleet Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants