Gitopts reconciler just deletes the Bundle, not BundleDeployments #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we are using finalizers for Bundles we can let the Bundle reconciler deal with its BundleDeployments and just delete the Bundle in the gitopts reconciler. That way we avoid having race conditions between both reconcilers trying to delete the same BundleDeployments Related to: rancher#2586 Signed-off-by: Xavi Garcia <[email protected]>
weyfonk
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are using finalizers for Bundles we can let the Bundle reconciler deal with its BundleDeployments and just delete the Bundle in the gitops reconciler.
That way we avoid having race conditions between both reconcilers trying to delete the same BundleDeployments
Related to: #2586