Remove kubeapiwarning message via crds #2601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* this is taken from the diff against 0.9.3
manno
force-pushed
the
remove-kubeapiwarning-message-via-crds
branch
from
c964c02 to
c38d733
Compare
weyfonk
reviewed
Jul 4, 2024
| APIVersion string `json:"apiVersion,omitempty"` | ||
| // Kind is the k8s kind of the resource. | ||
| // +nullable | ||
| Kind string `json:"kind,omitempty"` | ||
| // Type is the type of the resource, e.g. "apiextensions.k8s.io.customresourcedefinition" or "configmap". | ||
| Type string `json:"type,omitempty"` |
There was a problem hiding this comment.
I am surprised to see that many other fields would be nullable but not this one 🤔
There was a problem hiding this comment.
Clearly indicated by line 5294 of the patch ... 😛
There was a problem hiding this comment.
Ah, sorry. I meant 5312
(this is so confusing to diff, I can't even link it)
weyfonk
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gitops controller was complaining about
KubeAPIWarningLogger unknown field "status.resources[0].perClusterState[0].patch.data"Diff against 0.9.3 showed some missing markers in the generated CRD.