Configurable git client timeout #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-se
force-pushed
the
2188-git-client-timeout
branch
from
d9b7676 to
f979e7e
Compare
manno
reviewed
Jul 12, 2024
| @@ -43,6 +44,9 @@ var _ = Describe("GitJob controller", func() { | |||
| ) | |||
|
|
|||
| JustBeforeEach(func() { | |||
| config.Set(&config.Config{ | |||
There was a problem hiding this comment.
This will affect all integration tests running after this one, I think?
But that doesn't matter I guess, is this just for initialization? Instead of initializing the config in some tests, could we make the code work with an empty config instead?
There was a problem hiding this comment.
I've added the initialization to the suite instead of the tests where possible and initialized it empty where possible.
p-se
force-pushed
the
2188-git-client-timeout
branch
from
f979e7e to
c3538ff
Compare
Fixes rancher#2188 Also fixes an issue in the config reconciler which has prevented the config from being reloaded when it was changed.
p-se
force-pushed
the
2188-git-client-timeout
branch
from
c3538ff to
f05c311
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2188
Also fixes an issue in the config reconciler which has prevented the
config from being reloaded when it was changed.